use LITT function to determine order of tracks, #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…optionally supply the previous order, so minimize tracks jumping to the end of the tree
cmalinmayor
reviewed
Nov 6, 2025
| [tid for tid, ptid in tracklet_to_parent_tracklet.items() if ptid == 0] | ||
| ) | ||
|
|
||
| # Optionally sort roots according to their position in prev_axis_order |
Collaborator
There was a problem hiding this comment.
Can we do this functionality in the LITT implementation?
Collaborator
Author
There was a problem hiding this comment.
Are you referring to using nx.topological_sort? I think we definitely should, otherwise it is kind of broken if your node order is not 'correct'.
Collaborator
Author
There was a problem hiding this comment.
(I suppose we can also add the prev_axis_order but that may be more application specific)
Collaborator
There was a problem hiding this comment.
I meant the prev_axis_order, I think it would be applicable to anyone who is editing tracks
cmalinmayor
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also optionally supply the previous order, to minimize tracks jumping to the end of the tree.
The
get_sorted_tracksfunction needed to be adjusted to iterate over the nodes by topological order (usingnx.topological_sort(graph)), because when deleting an entire track, and undoing that action, the nodes are added back in reverse order, and because of that the parent tracklet is not correctly determined.This PR should also fix a bug I just discovered on Main: when you delete an entire lineage, except for one node, the application freezes on calculating the tree 😬