Returning to Napari #208
Merged
Returning to Napari #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmalinmayor
reviewed
Sep 29, 2025
I chose this approach because these tests are likely to be moved to funtracks in the near future, so a temporary duplication is easier than moving all the test to a central location.
cmalinmayor
approved these changes
Sep 29, 2025
Collaborator
There was a problem hiding this comment.
@AnniekStok I think this is ready, once you test and make sure the changes didn't mess up any functionality. I think specifically the pyqt6 update might be the thing I'm most worried about, even though it should be the same. If you test this and it works, let's merge!
Collaborator
Author
|
Yes it works for me (including the tests!) 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #208