Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated PR from Repo Assist.
Problem
Markdown.ToMd— the round-trip Markdown-to-Markdown serialiser — had zero test coverage in the test suite. Any regression inMarkdownUtils.fs'sformatSpanorformatParagraphfunctions would go undetected.Changes
Added 16 new NUnit test cases to
tests/FSharp.Markdown.Tests/Markdown.fscovering all the major span and paragraph types thatToMdcurrently handles:$...$)A small
toMdhelper normalises newlines to\nand strips trailing whitespace so tests are platform-independent.Test Status
dotnet build FSharp.Formatting.sln --configuration Release— succeeded (1 pre-existing FS0760 warning, unrelated)dotnet test tests/FSharp.Markdown.Tests/— 275 passed (was 259; +16 new, 0 failed)dotnet fantomas tests/FSharp.Markdown.Tests/Markdown.fs --check— no issues after formattingNotes
Emphasiscurrently renders identically toStrong(**...**) inMarkdownUtils.fs. This is existing behaviour; the tests document it without changing it.IndirectImageis still unimplemented (failwith "tbd") — tests for that case are being tracked in PR [Repo Assist] Fix crash in Markdown.ToMd when document contains indirect images #1094.