10000 fwget: Add GPU names to pci_video_amd by levelad · Pull Request #1702 · freebsd/freebsd-src · GitHub
[go: up one dir, main page]

Skip to content

fwget: Add GPU names to pci_video_amd #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

levelad added 2 commits May 18, 2025 16:23
Signed-off-by: Pascal Herget levelad@arcor.de
Signed-off-by: Pascal Herget levelad@arcor.de
Copy link
Author
@levelad levelad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put comments above the case to match pci_video_intel format.

@concussious concussious requested a review from evadot May 19, 2025 18:23
8000 Copy link

Thank you for taking the time to contribute to FreeBSD!
There is an issue that needs to be fixed:

  • Missing Signed-off-by lines27a31e6

Signed-off-by: Pascal Herget levelad@arcor.de
Copy link
Author
@levelad levelad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used correct meta-character '?' instead of '*' for all device IDs. [x]

Corrected 4 problematic device IDs:

0x13* -> 0x130?|0x131? (0x13* would cover 0x13e9 [Ariel/Navi10Lite], 0x13f9 [Oberon/Navi12Lite] and 0x13fe [Cyan Skillfish]) [x]
0x664*|0x664* -> 0x664? (duplicates) [x]
0x98e4* -> 0x98e4 (unnecessary asterisk, already 4 hexadecimals) [x]
0x73e*|0x73f* -> 0x73e?|0x73ff (0x73f* would cover 0x73f0 which is Navi 33) [x]

Put Polaris 10-12 in the right order. [x]

Added GPU name comments for Navi 21-24, Oberon (Cyan Skillfish) and Rembrandt (Yellow Carp). [x]

Added GPU name comments for Aldebaran and Van Gogh just to close the gaps. [x]

Moved Oberon after Navi 21. [x]

Moved Rembrandt and Van Gogh after Navi 24 (release date). [x]

Moved Raphael before Navi 31. [x]

Added 0x13e9 [Ariel/Navi10Lite] and 0x13f9 [Oberon/Navi12Lite] to Oberon. [x]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0