[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: force mocha to exit when 0 tests #42357

Merged
merged 1 commit into from
Jun 4, 2021
Merged

fix: force mocha to exit when 0 tests #42357

merged 1 commit into from
Jun 4, 2021

Conversation

ojeytonwilliams
Copy link
Contributor

Otherwise a command like

npm run test:curriculum -- -g 'Not a real title'

will spin forever

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • I have tested these changes either locally on my machine, or GitPod.

@ojeytonwilliams
fix: force mocha to exit when 0 tests
c84d55c 
Otherwise a command like

npm run test:curriculum -- -g 'Not a real title'

will spin forever
@gitpod-io
Copy link
gitpod-io bot commented Jun 4, 2021

ShaunSHamilton
ShaunSHamilton approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member
@ShaunSHamilton ShaunSHamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it works 👍

@ShaunSHamilton ShaunSHamilton added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Jun 4, 2021
Sembauke
Sembauke approved these changes Jun 4, 2021
View reviewed changes
Copy link
Member
@Sembauke Sembauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Sembauke Sembauke merged commit 8290ad0 into freeCodeCamp:main Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sembauke Sembauke Sembauke approved these changes

@ShaunSHamilton ShaunSHamilton ShaunSHamilton approved these changes

Assignees
No one assigned
Labels
status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ojeytonwilliams @Sembauke @ShaunSHamilton