[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update specify-how-fonts-should-degrade.md #42335

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

impirios
Copy link
Contributor
@impirios impirios commented Jun 2, 2021

Added a period at the end of the second sentence "These generic font families include monospace, serif and sans-serif".

Checklist:

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the main branch of freeCodeCamp.
  • I have tested these changes either locally on my machine, or GitPod.

Closes #XXXXX

Added a period at the end of the second sentence "These generic font families include monospace, serif and sans-serif".
@gitpod-io
Copy link
gitpod-io bot commented Jun 2, 2021

@github-actions github-actions bot added the scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. label Jun 2, 2021
@impirios
Copy link
Contributor Author
impirios commented Jun 2, 2021

Added a period at the end of the second sentence "These generic font families include monospace, serif and sans-serif"

@SethFalco
Copy link
Member

Hey, and welcome to the repository! 👋

Just a heads-up, you can populate the "Closes" field in the PR description with "Closes #42331", and it'll automatically close that issue when or if this gets merged.

Copy link
Member
@SethFalco SethFalco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍🏽

Copy link
Member
@Nirajn2311 Nirajn2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Nirajn2311 Nirajn2311 merged commit f7ca979 into freeCodeCamp:main Jun 2, 2021
@Nirajn2311
Copy link
Member

Hi @impirios. Congrats on your first pull request (PR)! 🎉

Thank you for your contribution to the page! 👍
We are happy to accept these changes and look forward to future contributions. 📝

@gikf gikf mentioned this pull request Jun 2, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants