Conversation
|
|
||
| private static class UidCacheItem { | ||
| private int count = 1; | ||
| private Instant age = Instant.now(); |
There was a problem hiding this comment.
age should be final
| private Instant age = Instant.now(); | |
| private final Instant age = Instant.now(); |
| Uid uid = iter.iterate(); | ||
|
|
||
| if (uid == null || Uid.nullUid().equals(uid)) break; |
There was a problem hiding this comment.
Beetje rare manier om de loop te schrijven, kan het niet met een for loop?
(Lijkt me een copy-paste van elders 😉 )
There was a problem hiding this comment.
Ja klopt, uit de narayana code zelf
| transactionmanager.jdbc.connection.testQuery= | ||
|
|
||
| ## Use the native Narayana JDBC pooling mechanism instead of DBCP2 | ||
| transactionmanager.narayana.jdbc.nativePoolingMechanism=false |
There was a problem hiding this comment.
Ik ben benieuwd wat de invloed op onze tests is als we dit op true zetten. Zowel in unit-tests (met echte database, niet H2) en in onze Tomcat+Narayana Larva tests.
core/src/main/java/org/frankframework/jta/narayana/HeuristicDetectingRecoveryModule.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/frankframework/jta/narayana/HeuristicDetectingRecoveryModule.java
Outdated
Show resolved
Hide resolved
| ds = new NarayanaDataSource(xaDataSource, dataSourceName); | ||
| log.info("created non XA-enabled PoolingDataSource [{}]", ds); | ||
| NarayanaDataSource nds = new NarayanaDataSource(xaDataSource, dataSourceName); | ||
| nds.setConnectionPooling(useNativePoolingMechanism); |
There was a problem hiding this comment.
Is het een idee om deze mee te nemen als constructor params ipv setters?
Co-authored-by: Erik <dongenevan@gmail.com>
|
There was a problem hiding this comment.
TransactionManager tests die eerder fout gingen met MS SQL Server gaan nu goed.
Enorme stap voorruit in de betrouwbaarheid van onze transaction-manager integratie en customizations.
No description provided.