10BC0 Update GitHub actions/checkout to v4 by jkosternl · Pull Request #5782 · frankframework/frankframework · GitHub
[go: up one dir, main page]
Skip to content

Update GitHub actions/checkout to v4 #5782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2023
Merged

Update GitHub actions/checkout to v4 #5782

merged 1 commit into from
Nov 16, 2023

Conversation

jkosternl
Copy link
Contributor

No description provided.

@jkosternl jkosternl requested review from tnleeuw and nielsm5 November 16, 2023 10:57
@jkosternl jkosternl self-assigned this Nov 16, 2023
@tnleeuw
Copy link
Contributor
tnleeuw commented Nov 16, 2023

Two points I want to raise before approving:

  1. None of the workflows that have been updated, has actually been triggered. So while nothing should break I'm still a bit hesitant to approve.
  2. Once approved this change should be backported to all branches we are still maintaining. (I'm not entirely certain if that should include 7.7-release or not at this point b/c I'm not sure what the contracts say).

@jkosternl
Copy link
Contributor Author

Two points I want to raise before approving:

Thanks @tnleeuw, I didn't know about that. I used the checkout action on the Frank-Doc project already. At least, I thought it is used to checkout the project and IAF.
I will backport it too, when needed. Wasn't aware of that.

@tnleeuw
Copy link
Contributor
tnleeuw commented Nov 16, 2023

Two points I want to raise before approving:

Thanks @tnleeuw, I didn't know about that. I used the checkout action on the Frank-Doc project already. At least, I thought it is used to checkout the project and IAF. I will backport it too, when needed. Wasn't aware of that.

Thanks, knowing you already use this version in the Frank!Doc project without need to change anything else makes me feel more confident to approve it here!

@nielsm5
Copy link
Member
nielsm5 commented Nov 16, 2023

Two points I want to raise before approving:

  1. None of the workflows that have been updated, has actually been triggered. So while nothing should break I'm still a bit hesitant to approve.
  2. Once approved this change should be backported to all branches we are still maintaining. (I'm not entirely certain if that should include 7.7-release or not at this point b/c I'm not sure what the contracts say).

I doubt it will have a significant impact. So I don't think a backport to 7.7/7.8 is required. The only change so far seems to be partial checkout filters.

@nielsm5 nielsm5 merged commit f5c945c into master Nov 16, 2023
@nielsm5 nielsm5 deleted the feature/updateGitHubActionsCheckout branch November 16, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnleeuw tnleeuw tnleeuw approved these changes

@nielsm5 nielsm5 nielsm5 approved these changes

Assignees

@jkosternl jkosternl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkosternl @tnleeuw @nielsm5
0