bump storybook, react, three, yarn, etc #427
Conversation
| "outDir": "./dist/cjs", | ||
| "module": "commonjs" | ||
| "module": "commonjs", | ||
| "moduleResolution": "node10" |
There was a problem hiding this comment.
microsoft/TypeScript#62200 (comment)
changing to esnext and bundler is an option? It seems that it will be deprecated soon, maybe we can already update it
There was a problem hiding this comment.
This is a separate tsconfig for building as cjs (we build and distribute both cjs + esm for most of our published packages), so we cannot switch to module: esnext. Maybe we could use bundler, not sure if the moduleResolution matters as much, I just kept this to avoid changing too much. I guess we can revisit when TS 6.0 is out?
There was a problem hiding this comment.
just a small question about the node10. But if it gets too much trouble to update it, I guess we can let as it is until we need to bump typescript to v6+
Some things that dependabot was having trouble bumping on its own. Minor tweaking required.
I am hoping the tsconfig change, as well as the
THREE.Texture<THREE.DataTextureImageData>type change will not affect downstream consumers?