8000 Fixed php 8.0 support by jacob-v-dam · Pull Request #3538 · forkcms/forkcms · GitHub
[go: up one dir, main page]
Skip to content

Fixed php 8.0 support#3538

Merged
carakas merged 11 commits intoforkcms:masterfrom
jacob-v-dam:upgrade-package-for-php-8
Jul 31, 2023
Merged

Fixed php 8.0 support#3538
carakas merged 11 commits intoforkcms:masterfrom
jacob-v-dam:upgrade-package-for-php-8

Conversation

@jacob-v-dam
Copy link
Contributor
@jacob-v-dam jacob-v-dam commented Dec 5, 2022 •
edited
Loading

Type

  • Enhancement

Resolves the following issues

Adds PHP 8.0 support. PHP 7.1 is not supported anymore.

Pull request description

Upgrade packages and code to support PHP 7.4 and PHP 8.0. PHP 7.1 is not supported anymore.

@jacob-v-dam jacob-v-dam requested a review from a team as a code owner December 5, 2022 08:59
@jacob-v-dam jacob-v-dam force-pushed the upgrade-package-for-php-8 branch 4 times, most recently from b26c559 to e4b1159 Compare December 5, 2022 09:11
@codecov
Copy link
codecov bot commented Dec 5, 2022 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.09% ⚠️

Comparison is base (25bea7d) 27.88% compared to head (246579d) 27.80%.

❗ Current head 246579d differs from pull request most recent head e23e330. Consider uploading reports for the commit e23e330 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #3538      +/-   ##
============================================
- Coverage     27.88%   27.80%   -0.09%     
- Complexity     8152     8187      +35     
============================================
  Files           575      576       +1     
  Lines         30716    30799      +83     
============================================
- Hits           8565     8563       -2     
- Misses        22151    22236      +85
Flag Coverage Δ
functional 23.72% <0.00%> (-0.08%) ⬇️
installer 3.83% <0.00%> (-0.02%) ⬇️
unit 7.66% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ry/Domain/MediaItem/MediaItemSelectionDataGrid.php 0.00% <0.00%> (ø)
src/Common/Core/Model.php 49.49% <ø> (-1.01%) ⬇️
src/ForkCMS/Imagine/Service/FilterService.php 0.00% <0.00%> (ø)
src/ForkCMS/ImagineController.php 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacob-v-dam jacob-v-dam force-pushed the upgrade-package-for-php-8 branch 2 times, most recently from c5feaa4 to 246579d Compare December 5, 2022 09:42
carakas
carakas requested changes Feb 20, 2023
View reviewed changes
@jacob-v-dam jacob-v-dam force-pushed the upgrade-package-for-php-8 branch from b55a5fc to 9b01216 Compare July 25, 2023 17:10
@jacob-v-dam jacob-v-dam force-pushed the upgrade-package-for-php-8 branch from 9b01216 to 5ff3cff Compare July 25, 2023 17:10
@jacob-v-dam jacob-v-dam force-pushed the upgrade-package-for-php-8 branch 2 times, most recently from b02fc52 to 98b2284 Compare July 25, 2023 18:49
@jacob-v-dam jacob-v-dam force-pushed the upgrade-package-for-php-8 branch from 98b2284 to bb8e7d6 Compare July 25, 2023 18:51
@jacob-v-dam jacob-v-dam force-pushed the upgrade-package-for-php-8 branch from 3fa3791 to e23e330 Compare July 25, 2023 19:01
@carakas
Copy link
Member
carakas commented Jul 26, 2023

Thanks for updating @jacob-v-dam, I'll review it this weekend

@jacob-v-dam
Copy link
Contributor Author
jacob-v-dam commented Jul 26, 2023

Thanks for updating @jacob-v-dam, I'll review it this weekend

That would be perfect! The next step is to jump to Symfony 5.4 which is LTS for now.

@carakas carakas merged commit 8dfc3db into forkcms:master Jul 31, 2023
@carakas carakas mentioned this pull request Jul 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carakas carakas carakas approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.12.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jacob-v-dam @carakas
0