Make the old session clean-up method timezone aware#3511
Merged
carakas merged 2 commits intoforkcms:masterfrom May 5, 2022
Merged
Make the old session clean-up method timezone aware#3511carakas merged 2 commits intoforkcms:masterfrom
carakas merged 2 commits intoforkcms:masterfrom
Conversation
added 2 commits
May 5, 2022 12:06
This fixes a bug where the database timezone would be different from UTC, and the date inserted into the database would be incorrectly removed by the NOW() check.
Codecov Report
@@ Coverage Diff @@
## master #3511 +/- ##
=========================================
Coverage 27.87% 27.87%
Complexity 8150 8150
=========================================
Files 575 575
Lines 30705 30706 +1
=========================================
+ Hits 8559 8560 +1
Misses 22146 22146
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
carakas
approved these changes
May 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Resolves the following issues
/
Pull request description
This fixes a bug where the database timezone would be different from
UTC, and the date inserted into the database would be incorrectly removed
by the NOW() check.