BUGFIX: Fix Breadcrumb Style#3487
Merged
carakas merged 4 commits intoforkcms:masterfrom Jan 8, 2022
crydotsnake:bugfix/breadcrumb-style
Merged
BUGFIX: Fix Breadcrumb Style#3487carakas merged 4 commits intoforkcms:masterfrom crydotsnake:bugfix/breadcrumb-style
carakas merged 4 commits intoforkcms:masterfrom
crydotsnake:bugfix/breadcrumb-style
Conversation
added 2 commits
December 24, 2021 21:56
This fixes the bug, described in the issue #3474
This commit adds the .idea folder to the .gitignore file. So in the feature, the .idea folder will be ignored from git.
Codecov Report
@@ Coverage Diff @@
## master #3487 +/- ##
=========================================
Coverage 27.88% 27.88%
Complexity 8145 8145
=========================================
Files 575 575
Lines 30691 30691
=========================================
Hits 8557 8557
Misses 22134 22134
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
carakas
requested changes
Jan 1, 2022
| <ul class="breadcrumb" itemscope itemtype="https://schema.org/BreadcrumbList" role="navigation"> | ||
| {% for breadcrumb in breadcrumb %} | ||
| <li{% if loop.last %} class="active"{% endif %} itemprop="itemListElement" itemscope | ||
| <li{% if loop.last %} class="breadcrumb-item active"{% endif %} itemprop="itemListElement" itemscope |
Member
There was a problem hiding this comment.
I think it should be
Suggested change
| <li{% if loop.last %} class="breadcrumb-item active"{% endif %} itemprop="itemListElement" itemscope | |
| <li class="breadcrumb-item{% if loop.last %} active{% endif %}" itemprop="itemListElement" itemscope |
carakas
requested changes
Jan 2, 2022
carakas
approved these changes
Jan 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug described in the issue #3474