SpoonLibrary expects the charset to be in lowercase, otherwise some xss protections fail#3455
Merged
carakas merged 1 commit intoforkcms:masterfrom Sep 1, 2021
Conversation
…ss protections fail
Codecov Report
@@ Coverage Diff @@
## master #3455 +/- ##
=========================================
Coverage 27.88% 27.88%
Complexity 8145 8145
=========================================
Files 575 575
Lines 30690 30690
=========================================
Hits 8558 8558
Misses 22132 22132
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
tijsverkoyen
approved these changes
Sep 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Pull request description
Spoon library doesn't encode some things well when the charset isn't utf-8 but UTF-8. This causes some xss issues