Copy forms and their widgets when making a language copy#3445
Merged
carakas merged 1 commit intoforkcms:masterfrom Aug 18, 2021
Merged
Copy forms and their widgets when making a language copy#3445carakas merged 1 commit intoforkcms:masterfrom
carakas merged 1 commit intoforkcms:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3445 +/- ##
============================================
- Coverage 27.94% 27.88% -0.06%
- Complexity 8131 8145 +14
============================================
Files 573 575 +2
Lines 30628 30689 +61
============================================
Hits 8558 8558
- Misses 22070 22131 +61
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
carakas
approved these changes
Aug 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Resolves the following issues
/
Pull request description
When making a copy of a language using the hidden Pages copy action, forms would not be duplicated for the new language, and the content blocks on the new pages would still refer to the old form (in the source language). This results in a lot of weird behaviour if you started editing these forms and moving the widgets.
This PR properly duplicates each form (and its fields + validations) found on an active page, updates the language of that form to the new locale and then adds a new content block with the new ID.