8000 Reuse existing variable by tijsverkoyen · Pull Request #3443 · forkcms/forkcms · GitHub
[go: up one dir, main page]

Skip to content

Reuse existing variable#3443

Merged
carakas merged 1 commit intomasterfrom
reuse-variable
Aug 18, 2021
Merged

Reuse existing variable#3443
carakas merged 1 commit intomasterfrom
reuse-variable

Conversation

@tijsverkoyen
Copy link
Member

Type

  • Enhancement

Pull request description

Minor optimalisation: use the existing $database variable instead of retrieving it from the container again.

@tijsverkoyen tijsverkoyen requested a review from carakas August 6, 2021 09:42
@codecov
Copy link
codecov bot commented Aug 6, 2021

Codecov Report

Merging #3443 (da730a8) into master (a492bd5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3443   +/-   ##
=========================================
  Coverage     27.94%   27.94%           
  Complexity     8129     8129           
=========================================
  Files           573      573           
  Lines         30613    30613           
=========================================
  Hits           8556     8556           
  Misses        22057    22057           
Flag Coverage Δ
functional 23.84% <ø> (ø)
installer 3.85% <ø> (ø)
unit 7.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a492bd5...da730a8. Read the comment docs.

@carakas carakas merged commit 1bd5e85 into master Aug 18, 2021
@carakas carakas deleted the reuse-variable branch August 18, 2021 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0