Fix mapping old content blocks when copying pages#3442
Merged
carakas merged 1 commit intoforkcms:masterfrom Aug 18, 2021
Merged
Fix mapping old content blocks when copying pages#3442carakas merged 1 commit intoforkcms:masterfrom
carakas merged 1 commit intoforkcms:masterfrom
Conversation
tijsverkoyen
approved these changes
Aug 5, 2021
Codecov Report
@@ Coverage Diff @@
## master #3442 +/- ##
============================================
+ Coverage 27.61% 27.94% +0.33%
- Complexity 8115 8129 +14
============================================
Files 572 573 +1
Lines 30975 30613 -362
============================================
+ Hits 8553 8556 +3
+ Misses 22422 22057 -365
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
carakas
approved these changes
Aug 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Pull request description
When copying pages with content blocks on, through the hidden copy pages action, the mapping of old to new content block/module extra id didn't work properly. The block extra id was a string and the content block extra id was an int. With the strict parameter of in_array, this wasn't mapped correctly after the copy.