Fix search total for short terms#3441
Merged
carakas merged 1 commit intoforkcms:masterfrom Aug 6, 2021
Merged
Conversation
tijsverkoyen
approved these changes
Aug 5, 2021
Codecov Report
@@ Coverage Diff @@
## master #3441 +/- ##
============================================
+ Coverage 27.61% 27.94% +0.32%
- Complexity 8115 8131 +16
============================================
Files 572 573 +1
Lines 30975 30628 -347
============================================
+ Hits 8553 8558 +5
+ Misses 22422 22070 -352
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
carakas
approved these changes
Aug 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Pull request description
Just like we use a simple SQL query for the short terms for searching for results: https://github.com/forkcms/forkcms/blob/master/src/Frontend/Modules/Search/Engine/Model.php#L126 - we need this for the getTotal call, otherwise it might give the wrong total (0 in my case).