Merged
Conversation
carakas
approved these changes
Aug 2, 2021
tijsverkoyen
approved these changes
Aug 2, 2021
Codecov Report
@@ Coverage Diff @@
## master #3440 +/- ##
=========================================
Coverage 27.61% 27.61%
Complexity 8115 8115
=========================================
Files 572 572
Lines 30975 30975
=========================================
Hits 8553 8553
Misses 22422 22422
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Pull request description
When deleting cookies, the current code adds a cookie with 1s expire time, but the next line removes this cookie again. Swapping those lines fixes this issue.
Note: there is also another issue that the deleting of cookie on RedirectResponse (Logout) is not persisted. But the Authentication has a backup check where it gets deleted in a "normal" fork action, which works.