Duplicate page image when copying pages from one locale to another#3438
Merged
carakas merged 3 commits intoforkcms:masterfrom Aug 2, 2021
Merged
Duplicate page image when copying pages from one locale to another#3438carakas merged 3 commits intoforkcms:masterfrom
carakas merged 3 commits intoforkcms:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3438 +/- ##
============================================
- Coverage 27.61% 27.59% -0.02%
- Complexity 8115 8121 +6
============================================
Files 572 572
Lines 30975 30992 +17
============================================
Hits 8553 8553
- Misses 22422 22439 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| $database->update('meta', ['url' => $newUrl], 'id = ?', [$page['meta_id']]); | ||
| } | ||
|
|
||
| private static function getImage(?string $image, string $metaUrl): ?string |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niet logischer om dit copyImage te noemen? of getCopiedImage
tijsverkoyen
approved these changes
Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<
75A8
/template>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Resolves the following issues
When copying pages from one locale to another (with the hidden action /en/pages/copy?from=en&to=nl), the page image will be linked to the same file. Which when you change the image in one of the user template, the other will be broken as the original image gets deleted.
Pull request description
Duplicate the page image when copying pages from one locale to another.