8000 Update code for Google reCAPTCHA v3 by jonasdekeukelaere · Pull Request #3409 · forkcms/forkcms · GitHub
[go: up one dir, main page]

Skip to content

Update code for Google reCAPTCHA v3#3409

Merged
carakas merged 3 commits intoforkcms:masterfrom
jonasdekeukelaere:414-google-recaptcha-v3
Jun 29, 2021
Merged

Update code for Google reCAPTCHA v3#3409
carakas merged 3 commits intoforkcms:masterfrom
jonasdekeukelaere:414-google-recaptcha-v3

Conversation

@jonasdekeukelaere
Copy link
Member
@jonasdekeukelaere jonasdekeukelaere commented May 25, 2021

Type

  • Enhancement

Pull request description

Adds option to choose Google reCAPTCHA version used. V2 invisible or v3.
https://developers.google.com/recaptcha/docs/invisible
https://developers.google.com/recaptcha/docs/v3

@carakas
Copy link
Member
carakas commented May 25, 2021

Is this a bugfix?
This seems like a backwards incompatible change so it is for Fork 6

@codecov
Copy link
codecov bot commented May 25, 2021

Codecov Report

Merging #3409 (fa077c6) into master (3caccf2) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3409      +/-   ##
============================================
- Coverage     27.79%   27.62%   -0.18%     
- Complexity     8010     8107      +97     
============================================
  Files           568      572       +4     
  Lines         30564    30945     +381     
============================================
+ Hits           8496     8549      +53     
- Misses        22068    22396     +328     
Flag Coverage Δ
functional 23.61% <0.00%> (-0.12%) ⬇️
installer 3.81% <0.00%> (-0.05%) ⬇️
unit 7.56% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Backend/Modules/Settings/Actions/Index.php 0.00% <0.00%> (ø)
src/Frontend/Modules/FormBuilder/Widgets/Form.php 0.00% <0.00%> (ø)
src/Backend/Core/Engine/Base/Widget.php 38.09% <0.00%> (-17.08%) ⬇️
src/Frontend/Core/Language/Language.php 51.66% <0.00%> (-3.34%) ⬇️
src/Backend/Core/Engine/Authentication.php 91.72% <0.00%> (-2.29%) ⬇️
src/Common/Doctrine/Entity/Meta.php 14.64% <0.00%> (-0.86%) ⬇️
src/Backend/Core/Engine/Meta.php 59.55% <0.00%> (-0.45%) ⬇️
src/Frontend/Core/Engine/Page.php 64.95% <0.00%> (-0.09%) ⬇️
src/Frontend/Core/Engine/Base/Block.php 54.27% <0.00%> (-0.05%) ⬇️
src/Backend/Form/Type/MetaType.php 0.00% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3caccf2...fa077c6. Read the comment docs.

Copy link
Member
@carakas carakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want this in fork 5 you need to create this in a BC way

@jonasdekeukelaere jonasdekeukelaere requested a review from a team as a code owner May 25, 2021 13:43
@jonasdekeukelaere
Copy link
Member Author
< B4D0 task-lists disabled sortable>

@carakas PR updated for Google reCAPTCHA version selection.

@carakas carakas removed the BC Break label May 25, 2021
@carakas carakas merged commit 13e7c56 into forkcms:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0