Merged
Conversation
If we want the dialog to be opened with example we need it to be present in the HTML.
!Important: this is potentially a breaking change.
A JS event is triggered in the document when the Consent dialog is submitted. * `privacyConsentChanged`: is always triggered when the dialog is submitted. * `privacyConsentLevelXXXAgreed`: is triggered when consent is given for that level. * `privacyConsentLevelXXXDisagreed`: is triggered when consent is not given for that level. `XXX` is replaced by the ucfirst version of the level.
Codecov Report
@@ Coverage Diff @@
## master #3372 +/- ##
=========================================
Coverage 27.74% 27.75%
- Complexity 8028 8029 +1
=========================================
Files 568 568
Lines 30624 30627 +3
=========================================
+ Hits 8497 8500 +3
Misses 22127 22127
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Katrienvh
approved these changes
Apr 22, 2021
carakas
approved these changes
Apr 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Pull request description
Trigger events
A JS event is triggered in the document when the Consent dialog is submitted.
privacyConsentChanged: is always triggered when the dialog is submitted.privacyConsentLevelXXXAgreed: is triggered when consent is given for that level.privacyConsentLevelXXXDisagreed: is triggered when consent is not given for that level.XXXis replaced by the ucfirst version of the level.Better rendering of the dialog.
Don't render HTML if the dialog is disabled through the settings. But render the HTML if it is enabled so you can open the dialog with JS.
Remark: If you include your own version of the HTML of the dialog you will need to implement the changes in your own theme.