updated to fix uses of MySQL reserved words#3264
Merged
carakas merged 1 commit intoforkcms:masterfrom Jan 2, 2021
Merged
Conversation
Per forkcms#3260 (comment) - updated with temporary fix to address issues with mysql reserved words: user(s) and group(s). For now, uses of those table names are just encapsulated in literals e.g. ```SELECT * from `group`;``` although it may be better to change the installer code to create DB table prefixes. Creator notes that v6 branch has been refactored and this is a non-issue.
Codecov Report
@@ Coverage Diff @@
## master #3264 +/- ##
=========================================
Coverage 27.79% 27.79%
Complexity 8010 8010
=========================================
Files 568 568
Lines 30564 30564
=========================================
Hits 8496 8496
Misses 22068 22068
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
carakas
approved these changes
Jan 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #3260 (comment) - updated with temporary fix to address issues with mysql reserved words: user(s) and group(s). For now, uses of those table names are just encapsulated in literals e.g.
SELECT * from `group`;although it may be better to change the installer code to create DB table prefixes. Creator notes that v6 branch has been refactored and this is a non-issue.Type
Non critical bugfix
Resolves the following issues
Fixes #3260 in v5
Pull request description
Per #3260 (comment) - updated with temporary fix to address issues with mysql reserved words: user(s) and group(s). For now, uses of those table names are just encapsulated in literals e.g.
SELECT * from `group`;although it may be better to change the installer code to create DB table prefixes. Creator notes that v6 branch has been refactored and this is a non-issue.