8000 Test all php versions by carakas · Pull Request #3254 · forkcms/forkcms · GitHub
[go: up one dir, main page]
Skip to content

Test all php versions#3254

Merged
carakas merged 6 commits intoforkcms:masterfrom
justcarakas:test-all-php-versions
Dec 9, 2020
Merged

Test all php versions#3254
carakas merged 6 commits intoforkcms:masterfrom
justcarakas:test-all-php-versions

Conversation

@carakas
Copy link
Member
@carakas carakas commented Dec 9, 2020

Type

  • Non critical bugfix

Pull request description

The tests didn't run on all PHP versions, this should fix that

@carakas carakas added this to the 5.9.3 milestone Dec 9, 2020
@carakas carakas requested a review from a team as a code owner December 9, 2020 18:19
@codecov
Copy link
codecov bot commented Dec 9, 2020 •
edited
Loading

Codecov Report

Merging #3254 (30e70a0) into master (6370ea0) will decrease coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3254      +/-   ##
============================================
- Coverage     28.19%   27.79%   -0.40%     
+ Complexity     8012     8010       -2     
============================================
  Files           568      568              
  Lines         30652    30564      -88     
============================================
- Hits           8642     8496     -146     
- Misses        22010    22068      +58
Flag Coverage Δ Complexity Δ
functional 23.73% <ø> (-0.17%) 0.00 <ø> (ø)
installer 3.86% <ø> (-0.02%) 0.00 <ø> (ø)
unit 7.63% <ø> (-0.15%) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...rkCMS/Bundle/CoreBundle/Validator/UrlValidator.php 80.00% <0.00%> (-20.00%) 1.00% <0.00%> (ø%)
src/Frontend/Core/Header/MetaLink.php 76.78% <0.00%> (-10.72%) 12.00% <0.00%> (ø%)
src/Backend/Modules/Blog/Actions/Delete.php 71.42% <0.00%> (-10.72%) 6.00% <0.00%> (ø%)
...ckend/Modules/Analytics/GoogleClient/Connector.php 77.39% <0.00%> (-8.70%) 24.00% <0.00%> (ø%)
src/Common/Doctrine/Entity/CreateSchema.php 83.33% <0.00%> (-8.34%) 3.00% <0.00%> (ø%)
...Frontend/Core/Engine/FormFieldErrorTokenParser.php 68.75% <0.00%> (-6.25%) 3.00% <0.00%> (ø%)
src/Backend/Form/Type/DeleteType.php 60.00% <0.00%> (-5.00%) 2.00% <0.00%> (ø%)
src/Frontend/Modules/Faq/Actions/Index.php 95.00% <0.00%> (-5.00%) 3.00% <0.00%> (ø%)
src/Common/EventListener/ResponseSecurer.php 95.00% <0.00%> (-5.00%) 7.00% <0.00%> (ø%)
...Bundle/InstallerBundle/Requirement/Requirement.php 47.61% <0.00%> (-4.77%) 7.00% <0.00%> (ø%)
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6370ea0...30e70a0. Read the comment docs.

jessedobbelaere
jessedobbelaere approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member
@jessedobbelaere jessedobbelaere left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. We went from 10-15min (travis?) to 9min (GitHub actions), to 2minutes (pcov instead of xdebug) to run the functional tests 🕺 👏 Nice improvement!

@carakas carakas merged commit f3b36e6 into forkcms:master Dec 9, 2020
@carakas carakas deleted the test-all-php-versions branch March 21, 2021 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jessedobbelaere jessedobbelaere jessedobbelaere approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.9.3

Development

Successfully merging this pull request may close these issues.

2 participants

@carakas @jessedobbelaere
0