8000 Pin xdebug v2 for PHP 7.1 support by jessedobbelaere · Pull Request #3246 · forkcms/forkcms · GitHub
[go: up one dir, main page]

Skip to content

Pin xdebug v2 for PHP 7.1 support#3246

Merged
carakas merged 1 commit intoforkcms:masterfrom
jessedobbelaere:fix-docker-php-xdebug
Nov 30, 2020
Merged

Pin xdebug v2 for PHP 7.1 support#3246
carakas merged 1 commit intoforkcms:masterfrom
jessedobbelaere:fix-docker-php-xdebug

Conversation

@jessedobbelaere
Copy link
Member

Type

  • Non critical bugfix

Resolves the following issues

Pull request description

image

Recently xdebug 3 was release, which dropped support for PHP 7.1. We still support this version so we need to pin the version (https://pecl.php.net/package/xdebug)

@jessedobbelaere jessedobbelaere requested a review from a team as a code owner November 30, 2020 20:23
@carakas carakas added this to the 5.10.0 milestone Nov 30, 2020
@codecov
Copy link
codecov bot commented Nov 30, 2020

Codecov Report

Merging #3246 (612d1ba) into master (f8d89df) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3246   +/-   ##
=========================================
  Coverage     28.19%   28.19%           
  Complexity     8012     8012           
=========================================
  Files           568      568           
  Lines         30652    30652           
=========================================
  Hits           8642     8642           
  Misses        22010    22010           
Flag Coverage Δ Complexity Δ
functional 23.89% <ø> (ø) 0.00 <ø> (ø)
installer 3.87% <ø> (ø) 0.00 <ø> (ø)
unit 7.78% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8d89df...612d1ba. Read the comment docs.

@carakas carakas modified the milestones: 5.10.0, 5.9.2 Nov 30, 2020
@carakas carakas merged commit 706d3cf into forkcms:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0