8000 Upgrade phpstan by carakas · Pull Request #3227 · forkcms/forkcms · GitHub
[go: up one dir, main page]
Skip to content

Upgrade phpstan#3227

Merged
carakas merged 21 commits intoforkcms:masterfrom
justcarakas:jessedobbelaere-upgrade-phpstan
Nov 13, 2020
Merged

Upgrade phpstan#3227
carakas merged 21 commits intoforkcms:masterfrom
justcarakas:jessedobbelaere-upgrade-phpstan

Conversation

@carakas
Copy link
Member
@carakas carakas commented Nov 13, 2020

Type

  • Non critical bugfix
  • Enhancement

Resolves the following issues

Fixes #3210

Pull request description

Upgrade phpstan to the latest version and make it pass on level 1

jessedobbelaere and others added 15 commits November 1, 2020 01:26
@carakas carakas added this to the 5.9.2 milestone Nov 13, 2020
@carakas carakas requested a review from a team November 13, 2020 14:26
@codecov
Copy link
codecov bot commented Nov 13, 2020 •
edited
Loading

Codecov Report

Merging #3227 (4bc5e93) into master (e1a7047) will decrease coverage by 0.02%.
The diff coverage is 26.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3227      +/-   ##
============================================
- Coverage     28.21%   28.19%   -0.03%     
+ Complexity     8013     8012       -1     
============================================
  Files           567      568       +1     
  Lines         30629    30652      +23     
============================================
  Hits           8642     8642              
- Misses        21987    22010      +23
Flag Coverage Δ Complexity Δ
functional 23.89% <27.27%> (-0.02%) 0.00 <26.00> (ø)
installer 3.87% <0.00%> (-0.01%) 0.00 <26.00> (ø)
unit 7.78% <2.22%> (-0.01%) 0.00 <26.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/Backend/Core/Engine/Base/Widget.php 55.17% <0.00%> (+1.83%) 17.00 <0.00> (ø)
src/Backend/Core/Engine/Url.php 55.03% <0.00%> (ø) 55.00 <0.00> (ø)
...ContentBlocks/Domain/ContentBlock/ContentBlock.php 0.00% <ø> (ø) 22.00 <0.00> (ø)
src/Backend/Modules/FormBuilder/Ajax/SaveField.php 0.00% <0.00%> (ø) 89.00 <0.00> (ø)
src/Backend/Modules/FormBuilder/Engine/Model.php 0.00% <0.00%> (ø) 48.00 <0.00> (-1.00)
src/Backend/Modules/Groups/Actions/Add.php 0.00% <0.00%> (ø) 62.00 <0.00> (ø)
src/Backend/Modules/Groups/Actions/Edit.php 0.00% <0.00%> (ø) 75.00 <0.00> (ø)
src/Backend/Modules/Locale/Actions/Import.php 0.00% <ø> (ø) 11.00 <0.00> (ø)
...ediaGalleries/Domain/MediaGallery/MediaGallery.php 0.00% <ø> (ø) 21.00 <0.00> (ø)
...dules/MediaLibrary/Actions/MediaItemMassAction.php 0.00% <ø> (ø) 24.00 <0.00> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1a7047...4bc5e93. Read the comment docs.

jessedobbelaere
jessedobbelaere approved these changes Nov 13, 2020
View reviewed changes
Copy link
Member
@jessedobbelaere jessedobbelaere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job!! 🥇

src/Backend/Modules/MediaLibrary/Domain/MediaFolder/MediaFolder.php

/**
* @var ArrayCollection
* @var Collection<MediaFolder>
Copy link
Member
@jessedobbelaere jessedobbelaere Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@carakas carakas merged commit 603f39f into forkcms:master Nov 13, 2020
@carakas carakas deleted the jessedobbelaere-upgrade-phpstan branch November 13, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jessedobbelaere jessedobbelaere jessedobbelaere approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.9.2

Development

Successfully merging this pull request may close these issues.

2 participants

@carakas @jessedobbelaere
0