Add edit button to media item within a form#3192
Merged
carakas merged 2 commits intoforkcms:masterfrom May 3, 2021
Merged
Conversation
45632ef to
2165b7b
Compare
Codecov Report
@@ Coverage Diff @@
## master #3192 +/- ##
============================================
- Coverage 27.79% 27.77% -0.03%
- Complexity 8010 8017 +7
============================================
Files 568 569 +1
Lines 30564 30591 +27
============================================
Hits 8496 8496
- Misses 22068 22095 +27
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Member
|
@jacob-v-dam can you look at the feedback of the failing yarn test? |
added 2 commits
February 9, 2021 22:35
It is nice to edit the title from a media item within a from. When a there are a large amount of file it is hard to find the right file. With this addition it is possible to click the edit pencil to change the title.
a8fabd5 to
7d68e32
Compare
Contributor
Author
|
Yarn tests are fixed. I see that codecov is failing right now, but only the storage manager is tested. |
carakas
approved these changes
May 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is nice to edit the title of a media item within a from. When
there are a large amount of files it is hard to find the right file.
With this addition it is possible to click the edit pencil and change
the title.
Type
Resolves the following issues
Pull request description
With this function it would be able to change the title of a media item within a form. This means that the user doesn't have to search the whole library to find one item.