Move from Travis to GitHub Actions#3175
Merged
carakas merged 19 commits intoforkcms:masterfrom Oct 26, 2020
Merged
Conversation
2490a8b to
d87f100
Compare
Member
Author
|
Some fun automations possible for later: E.g. greeting a first contributor, auto labelling in github, ... https://github.com/actions/starter-workflows/tree/master/automation
|
Member
|
Nice! |
* 'master' of github.com:forkcms/forkcms: Always require a media item to have a title Update Add.php
Member
Author
|
I'm downgrading to Composer v1, since we run in Fork CMS 5.x on a minimum version of PHP 7.1. But Doctrine requires
|
Member
Author
Tests finish successfully now https://github.com/jessedobbelaere/forkcms/actions/runs/325952756 |
Member
|
Fork 6 is going to be either php 8 or 7.4 |
carakas
approved these changes
Oct 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Resolves the following issues
Pull request description
Talked to @carakas about the new Github Container Registry and was wondering if we should try Github actions or stay with Travis. There were some issues (?) in the past with Travis so I could give it a try.
Example:
https://github.com/jessedobbelaere/forkcms/actions/runs/325952756
Some notes:⚠️
symfony/phpunit-bridgeto * as documented by Symfony, because we pinned a pretty old version (v3 instead of v5). Causing our tests to run on phpunit 5 instead of 7 on travis and locally...On that note, do we have plans to move to PHP 7.2 or 7.3 as lowest supported version for Fork CMS? Needless to say, PHP 7.1 is EOL and PHP 7.2 very soon too: https://www.php.net/supported-versions.php
We need to add a token
CR_PATto the Github actions secrets, as mentioned on authenticating with github container registry. It should have read/write rights on repo packages. When we create a new release, it will push a docker container with the version tag and:latesttag to the container registry. This can be used for caching etc.We need to add
SCRUTINIZER_ACCESS_TOKENto the github action secrets, which we can probably take from Travis.On travis there was aFixed!yarn testjob in theafter_testsbut it always failed. Adding it back on github actions, it will fail the job so guess we need to fix the errors or decide to throw it out for now? :( I commented it out for now.Sadly, Github actions don't support Yaml anchors yet, or other ways to re-use blocks of code. This causes some code duplication in every job (define MySQL service, add PHP action, install dependencies, ...)
Added the
unzippackage to Dockerfile, since composer complained about it during docker build: