Bugfix: Skip default photo cropping if unchecked#3151
Merged
carakas merged 1 commit intoforkcms:masterfrom Jul 31, 2020
Merged
Conversation
Member
|
Nice :D Thanks Jesse |
carakas
approved these changes
Jul 19, 2020
This was referenced Jul 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5737
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Resolves the following issues
Fixes #2877
Pull request description
When we upload an image, it gets passed to the cropper by default, even if the cropper checkbox is unchecked before uploading. As Stijn mentions in #2877 when you upload his image of 392KB you end up with an image of 455KB.
By adding an early return in the scaling config, we bypass the cropper logic and end up with an uploaded image of 392KB still ✅
However, the Fine Uploader gets initialized when the page loads. Therefore, when we toggle the checkbox we have to destroy the uploader dropzone and re-init fineuploader with no scaling config (if cropper is disabled) or with custom scaling config (if cropper is enabled).
This fix will also allow for a fix for #3150 as the EXIF data is only removed when using the cropper 🙌 This means LiipImagineBundle can rotate images and strip the exif data properly.