8000 Fix mass action csrf token check by carakas · Pull Request #3138 · forkcms/forkcms · GitHub
[go: up one dir, main page]

Skip to content

Fix mass action csrf token check#3138

Merged
carakas merged 1 commit intoforkcms:masterfrom
justcarakas:fix-mass-action-csrf-token-check
Jul 2, 2020
Merged

Fix mass action csrf token check#3138
carakas merged 1 commit intoforkcms:masterfrom
justcarakas:fix-mass-action-csrf-token-check

Conversation

@carakas
Copy link
Member
@carakas carakas commented Jun 27, 2020

Type

  • Non critical bugfix

Pull request description

This fixes an unreleased bug introduced by #3123
This happens because we create the form manualy and use the get method. This overwrites the token in the form action
In spoon form we automatically add the token so it isn't an issue there.

@carakas carakas requested a review from a team as a code owner June 27, 2020 08:06
This happens because we create the form manualy and use the get method. This overwrites the token in the form action
In spoon form we automatically add the token so it isn't an issue there
@carakas carakas force-pushed the fix-mass-action-csrf-token-check branch from 436e211 to 10b737a Compare June 27, 2020 08:07
@carakas carakas added this to the 5.8.3 milestone Jun 27, 2020
@carakas carakas marked this pull request as draft June 27, 2020 09:03
@carakas carakas marked this pull request as ready for review June 27, 2020 10:50
@carakas carakas merged commit ead2ba5 into forkcms:master Jul 2, 2020
@carakas carakas deleted the fix-mass-action-csrf-token-check branch July 2, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet
42CF

Development

Successfully merging this pull request may close these issues.

3 participants

0