10BC0 Improve selected text color in dark mode for better readbility by prabhjeet127s · Pull Request #22130 · forem/forem · GitHub
[go: up one dir, main page]
Skip to content

Improve selected text color in dark mode for better readbility #22130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve selected text color in dark mode for better readbility #22130

wants to merge 2 commits into from

Conversation

prabhjeet127s
Copy link
@prabhjeet127s prabhjeet127s commented Jul 22, 2025 •
edited
Loading

Fixes #2799

Description

This pull request updates the selected text color in dark mode for better readability and visual contrast. The previous color was too subtle against the dark background, making it harder to identify selected text.

Changes Made

  • Modified the CSS in dark.css to set a more visible and accessible selection background color.

Why This Matters

This change enhances the overall user experience, especially for users working in low-light conditions or relying on visual contrast. It's a small but impactful UX improvement for the dark theme.

Testing

  • Verified the changes in a local environment.
  • Confirmed that the new selection color appears only in dark mode and does not affect the light theme.

@prabhjeet127s prabhjeet127s requested a review from a team as a code owner July 22, 2025 14:36
@github-actions GitHub Actions
Copy link
Contributor

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

@github-actions GitHub Actions
Copy link
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

@prabhjeet127s
Copy link
Author

Hi! The CLA check failed, but I'm unable to sign it.
When I visit https://cla-assistant.io/forem/forem, it says:
"There is no CLA to sign for forem/forem (could not find linked item)."

Can someone please check the CLA Assistant configuration?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add better color on selected text in dark mode
2 participants
@prabhjeet127s @benhalpern
0