[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Add menubar example #63

Merged
merged 1 commit into from
Nov 9, 2018
Merged

📖 Add menubar example #63

merged 1 commit into from
Nov 9, 2018

Conversation

roti
Copy link
Collaborator
@roti roti commented Nov 9, 2018

A small example for menu bars.

(I can't push directly to master anymore, did something change?)

@pmonks
Copy link
Contributor
pmonks commented Nov 9, 2018

@roti yeah I protected the master branch so that changes are unit tested before being merged to master. You followed the right workflow by creating a branch then submitting a PR, but if that's too onerous and/or we are still at a point where it makes more sense to live dangerously, I'd be open to unprotecting master.

Thoughts?

@pmonks pmonks merged commit 665cec5 into master Nov 9, 2018
@pmonks pmonks deleted the roti-examples branch November 9, 2018 17:12
@roti
Copy link
Collaborator Author
roti commented Nov 16, 2018

That's fine with me. The only drawback is that we'll have a lot of branches, but if we clean them up then it should be fine.

@pmonks
Copy link
Contributor
pmonks commented Nov 16, 2018

Yeah. Thankfully upon merging a branch, GitHub offers the option to delete the branch right then & there (and I make extensive use of that feature). It won't clean up branches in clones obviously, but at least the central repo stays clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants