bugfix: use correct field name for app metrics protocol#712
Merged
Conversation
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
kumare3
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in the serialization of scaling metrics to protobuf by ensuring that the correct field (
target_value) is used instead of the incorrect field (val). It also updates the related unit tests to verify the correct serialization behavior.Bug fix: Scaling metric serialization
_get_scaling_metricinapp_serde.pyto serializeScaling.ConcurrencyandScaling.RequestRatemetrics using thetarget_valuefield, as expected by the protobuf definitions, instead of the incorrectvalfield.Testing improvements
test_app_serde.pyto verify that thetarget_valuefield is correctly set in the resulting protobuf objects for bothConcurrencyandRequestRatemetrics, replacing previous tests that documented the bug.