New video constraints syntax #790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR currently only contains Android changes at the moment, but will update with changes for the other platforms; mainly requesting for comments rather than approval until then. The PR only handles the |
|
This should now cover all the currently supported platforms (web already handles the latest syntax). |
|
@cloudwebrtc @hiroshihorie please take a look at this PR. It resolves inconsistencies in media constraint specification. the PR is backwards compatible |
|
Nice update! |
|
LGTM |
cloudwebrtc
approved these changes
Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating getUserMedia to use latest video constraint syntax (https://developer.mozilla.org/en-US/docs/Web/API/MediaTrackConstraints).
Current getUserMedia constraints have been deprecated for years (and documentation is very sparse), so we should start looking to support the latest syntax.