8000 Do not call reStartCamera() for screen capture by XuanTung95 · Pull Request #552 · flutter-webrtc/flutter-webrtc · GitHub
[go: up one dir, main page]
Skip to content

Do not call reStartCamera() for screen capture #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2021
Merged

Do not call reStartCamera() for screen capture #552

merged 2 commits into from
May 2, 2021

Conversation

XuanTung95
Copy link
Contributor
@XuanTung95 XuanTung95 commented May 1, 2021 •
edited
Loading
  1. Fix bug** Screen Capture Android onResume: Cannot start already started MediaProjection #551
  • Add variable VideoCapturerInfo->isScreenCapture.
  • Do not call reStartCamera in case of screen capture
  1. Add options "cryptoOptions" when create peerconnection so user can enable Gcm crypto which is much faster.

@XuanTung95 XuanTung95 mentioned this pull request May 2, 2021
Merged
@cloudwebrtc
Copy link
Member

LGTM

@cloudwebrtc cloudwebrtc merged commit cfa1e88 into flutter-webrtc:master May 2, 2021
@cloudwebrtc
Copy link
Member

@XuanTung95 Can support cryptoOptions for iOS/macOS? I think other platforms also need consistency.

@cloudwebrtc
Copy link
Member

Has been added in this commit.
d3eaf16#diff-2496b27d4acaf6c7dc7482b1b221ccc92d20f720d1ca50d9aaffa404f0306564R1218

@XuanTung95
Copy link
Contributor Author

@XuanTung95 Can support cryptoOptions for iOS/macOS? I think other platforms also need consistency.

Idk, I only develop on Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XuanTung95 @cloudwebrtc
0