[Android] Fixed Track is null 'Sender is null' issues when removing track.
#401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the following issues:
In unified-plan when calling
mediaStream.removeTrack(sender.track)it throws track is null error because the track id is null as in the Java code it is calledtrackIdwhile in Dart code it anticipatesid.And also in
peerConnection.removeTrack(sender)it throws sender is null issue because in the java code the track id is compared with the==operator which compares reference instead of equality, it is replaced with the.equals()method to fix this issue.I have created the issue here #400