8000 Updated rtc_dtmf_sender by maanas · Pull Request #356 · flutter-webrtc/flutter-webrtc · GitHub
[go: up one dir, main page]
Skip to content

Updated rtc_dtmf_sender #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 26, 2020
Merged

Updated rtc_dtmf_sender #356

merged 2 commits into from
Sep 26, 2020

Conversation

maanas
Copy link
Contributor
@maanas maanas commented Sep 26, 2020

The api call is name insertDTMF
https://developer.mozilla.org/en-US/docs/Web/API/RTCDTMFSender/insertDTMF
renamed to function call to match with the WebRTC Api.

@maanas
Updated rtc_dtmf_sender
cf18d8b 
The api call is name insertDTMF
https://developer.mozilla.org/en-US/docs/Web/API/RTCDTMFSender/insertDTMF
renamed to function call to match with the WebRTC Api.
@cloudwebrtc
Copy link
Member

@maanas Thanks, renaming is good, the example also needs to be renamed, otherwise flutter analyze will report an error.
https://github.com/flutter-webrtc/flutter-webrtc/blob/master/example/lib/src/loopback_sample.dart#L182

@maanas
Updated loopback_example
5825d04 
Updated the loopback example for rename of sendDtmf to insertDTMF
@maanas
Copy link
Contributor Author
maanas commented Sep 26, 2020

@cloudwebrtc Thanks, I should have renamed the example. I have left _sendDtmf the function call as it is. As that depends on the user. Hope that is OK.
I will update the https://github.com/maanasnetwork/flutter_janus once these changes are pushed.

// pluginHandle.dtmfSender.insertDTMF(tones, duration, gap);
  pluginHandle.dtmfSender
      .sendDtmf(tones, duration: duration, interToneGap: gap);

@cloudwebrtc
Copy link
Member

LGTM

@cloudwebrtc cloudwebrtc merged commit 3c99ff3 into flutter-webrtc:master Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maanas @cloudwebrtc
0