8000 Fixed few callbacks not called by rostopira · Pull Request #23 · flutter-webrtc/flutter-webrtc · GitHub
[go: up one dir, main page]
Skip to content

Fixed few callbacks not called #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2018
Merged

Fixed few callbacks not called #23

merged 1 commit into from
Nov 13, 2018

Conversation

rostopira
Copy link
Collaborator

onIceConnectionState and onIceGatheringState wasn't called when onSignalingState is null

@rostopira
Fixed few callbacks not called
52b8584 
`onIceConnectionState` and `onIceGatheringState` wasn't called when `onSignalingState` is null
@rostopira
Copy link
Collaborator Author

Also, this bug could throw null pointer, if only onSignalingState is set

@cloudwebrtc cloudwebrtc merged commit 87fdd0d into flutter-webrtc:master Nov 13, 2018
@rostopira rostopira deleted the patch-3 branch November 13, 2018 16:22
@lintonv lintonv mentioned this pull request Dec 5, 2018
Closed
cloudwebrtc added a commit that referenced this pull request Jul 4, 2020
@cloudwebrtc
Merge pull request #23 from rostopira/patch-3
ddb2669 
Fixed few callbacks not called
@shivanshtalwar0 shivanshtalwar0 mentioned this pull request Oct 2, 2020
Closed
@mayder mayder mentioned this pull request Feb 9, 2021
Closed
@HoangPhamThai HoangPhamThai mentioned this pull request Dec 27, 2021
Open
@HoangPhamThai HoangPhamThai mentioned this pull request Jan 13, 2022
Closed
@ohari5336 ohari5336 mentioned this pull request Feb 23, 2022
Open