8000 Implemented audio only recording in media recorder for android and ios by yonatann · Pull Request #207 · flutter-webrtc/flutter-webrtc · GitHub
[go: up one dir, main page]

Skip to content

Implemented audio only recording in media recorder for android and ios #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 11, 2020

Conversation

yonatann
Copy link

I added an option for audio-only recording for android and implemented audio-only recording for ios.
There is still room to implement video recording for ios.

Copy link
Member
@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following changes should not be committed to the repository, as these are non-core files,

.dart_tool
android/.classpath
android/.project
android/gradle/wrapper/gradle-wrapper.properties
android/gradle/wrapper/gradle-wrapper.jar
android/gradlew
android/gradlew.bat

example/.dart_tool
example/.flutter-plugins-dependencies
example/android/.project
example/android/app/.classpath
example/ios/Flutter/flutter_export_environment.sh

Usually only .h .m .java .podspec .yml fixes need to be submitted.

8000

@cloudwebrtc
Copy link
Member

There seem to be three file conflicts preventing the merge

Conflicting files

example/android/gradle.properties
ios/Classes/FlutterWebRTCPlugin.m
ios/flutter_webrtc.podspec

@yonatann
Copy link
Author
yonatann commented Apr 6, 2020

I removed the non-core files and added them to .gitignore as you requested.
If you want me to resolve the conflicts then please give me write access.

Cheers

@yonatann yonatann requested a review from cloudwebrtc April 6, 2020 00:08
@cloudwebrtc
Copy link
Member

@yonatann Cool, I have added you to collaborators.

@yonatann
Copy link
Author
yonatann commented Apr 6, 2020

@cloudwebrtc I have resolved the conflicts and pushed the modifications.
Please note that I only tested on my usage scenario which is voice only.

@yonatann yonatann merged commit c818612 into flutter-webrtc:unified-plan May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0