Media Recorder implementation Android and iOS #1810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bantunes22
approved these changes
Apr 7, 2025
|
@cloudwebrtc Can you have a look at this? Tested on latest version of flutter and everything seems ok. |
|
hey, thanks for the PR, I will review this PR and its related later this week. |
| NSNumber* recorderId = argsMap[@"recorderId"]; | ||
| NSString* path = argsMap[@"path"]; | ||
| NSString* trackId = argsMap[@"videoTrackId"]; | ||
| NSString* audioTrackId = argsMap[@"audioTrackId"]; |
There was a problem hiding this comment.
I noticed that you had to use a dependency override just to provide audioTrackId. I used this workaround instead to avoid making additional changes.
- (NSString *)audioTrackIdForVideoTrackId:(NSString *)videoTrackId {
NSString *audioTrackId = nil;
// Iterate through all peerConnections
for (NSString *peerConnectionId in self.peerConnections) {
RTCPeerConnection *peerConnection = self.peerConnections[peerConnectionId];
// Iterate through the receivers to find the video track
for (RTCRtpReceiver *receiver in peerConnection.receivers) {
RTCMediaStreamTrack *track = [receiver valueForKey:@"track"];
if ([track.kind isEqualToString:@"video"] && [track.trackId isEqualToString:videoTrackId]) {
// Found the video track, now look for the audio track in the same peerConnection
for (RTCRtpReceiver *audioReceiver in peerConnection.receivers) {
RTCMediaStreamTrack *audioTrack = [audioReceiver valueForKey:@"track"];
if ([audioTrack.kind isEqualToString:@"audio"]) {
audioTrackId = audioTrack.trackId;
break;
}
}
break;
}
}
// If the audioTrackId is found, break out of the loop
if (audioTrackId != nil) {
break;
}
}
return audioTrackId;
}
There was a problem hiding this comment.
I followed your suggestion and created the audioTrackIdForVideoTrackId method. I also refactored the code and removed audioTrack from the methodChannel, since the videoTrack alone is sufficient. Please let me know if everything looks good.
There was a problem hiding this comment.
@cloudwebrtc can you check this?
|
LGTM |
kjawadDeveloper
approved these changes
Apr 22, 2025
cloudwebrtc
added a commit
that referenced
this pull request
Apr 29, 2025
This reverts commit 04ccd08.
cloudwebrtc
added a commit
that referenced
this pull request
Apr 29, 2025
cloudwebrtc
added a commit
that referenced
this pull request
Apr 29, 2025
cloudwebrtc
added a commit
that referenced
this pull request
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds media recorder support for iOS and fix Android implementation. The core implementation was originally submitted in this PR, but it had become outdated and had merge conflicts. I resolved the conflicts and fixed additional issues that appeared during testing.
Issues that were fixed:
The implementation has been tested across a variety of devices and appears to be working well.
Current behavior:
This PR depends on two other open PRs that must be merged first:
flutter-webrtc/webrtc-interface#31
flutter-webrtc/dart-webrtc#62
Feel free to request any changes — I’ll respond quickly, as the team needs this merged as soon as possible.
Edit: The pubspec.yaml is currently pointing to a different fork to ensure the build passes. Once the interface and dart-webRTC PR's are merged, the pubspec.yaml should be updated to point to the correct version.