[Android] fix: remove setPreferredInputDevice when getUserAduio. #1808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes the call to setPreferredInputDevice from the getUserAudio method to address hardware AEC/NS issues on specific Android devices during voice calls.
- Removed the setPreferredInputDevice block to avoid echo cancellation problems on Galaxy S25 Ultra and Galaxy Z Fold6.
- Simplified the audio track creation flow by eliminating unnecessary device-specific configuration.
Comments suppressed due to low confidence (1)
android/src/main/java/com/cloudwebrtc/webrtc/GetUserMediaImpl.java:365
- [nitpick] Since setPreferredInputDevice has been removed, consider reviewing the usage of deviceId. If it is no longer required in getUserAudio, removing it from the method's parameters could help clean up the code.
if (deviceId != null) { ... } // block removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
setPreferredInputDevicewill cause HW AEC/NS failure on some devices, causing echo during voice calls. Known devices include Galaxy S25 Ultra, Galaxy Z Fold6.In addition, we should avoid using Helper.selectAudioInput during a call to avoid causing echo cancellation failure on these devices.