8000 Partially rebuild RTCVideoView when renderVideo value changes by ycherniavskyi · Pull Request #1406 · flutter-webrtc/flutter-webrtc · GitHub
[go: up one dir, main page]
Skip to content

Partially rebuild RTCVideoView when renderVideo value changes #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2023
Merged

Partially rebuild RTCVideoView when renderVideo value changes #1406

merged 1 commit into from
Aug 3, 2023

Conversation

ycherniavskyi
Copy link
Member
@ycherniavskyi ycherniavskyi commented Aug 1, 2023 •
edited
Loading

When the srcObject value changes (and as a consequence, the renderVideo value of videoRenderer changes) in a place not related to the widget without a setState call (for example within a bloc), the associated RTCVideoView widget does not rebuild. As a result, it continues to display a placeholder or Container widget, even if RTCVideoRenderer.renderVideo is true.

In this pull request, I expand the usage of the ValueListenableBuilder widget, which already exists within RTCVideoView widget. This allows the actual renderVideo value to be respected and triggers a partial rebuild of the RTCVideoView widget when the value changes.

By the way in RTCVideoView for web this done by _onRendererListener callback that call setState.

 8000

wer-mathurin
wer-mathurin approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor
@wer-mathurin wer-mathurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cloudwebrtc
cloudwebrtc approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member
@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be 8000 displayed to describe this comment to others. Learn more.

lgtm

@cloudwebrtc cloudwebrtc merged commit 99f8182 into main Aug 3, 2023
@cloudwebrtc cloudwebrtc deleted the fix/rebuild-rtc-video-view-on-render-video-changed branch August 3, 2023 06:14
@cloudwebrtc
Copy link
Member
cloudwebrtc commented Aug 8, 2023 •
edited
Loading

This PR seems to cause flutter Windows (win 10) to not work correctly. To reproduce the steps, run getUserMedia or LoopBack Sample in the example, the randomness of the video rendering component cannot be displayed, use vs2022 debugging, flutter_video_renderer.cc::onFrame is called, but CopyPixelBuffer is not called by flutter, It seems that Texture is not rendering correctly in flutter UI.

@ycherniavskyi
Copy link
Member Author

Integrating. I've tried to investigate in this direction, but technically, this PR only introduced reaction to RTCVideoRenderer.renderVideo changes. Could it be possible that its value is being incorrectly reinitialized on Windows?

@cloudwebrtc
Copy link
Member
cloudwebrtc commented Aug 11, 2023 •
edited
Loading

I have no ideas, I tried some modifications, and only by reverting these changes and the Windows app can work, so I need to temporarily revert this PR until the issue with Windows rendering is resolved.

cloudwebrtc added a commit that referenced this pull request Aug 11, 2023
@cloudwebrtc
Revert "fix: partially rebuild RTCVideoView when renderVideo value ch…
2be4c26 
…anges (#1406)"

This reverts commit 99f8182.
@cloudwebrtc cloudwebrtc mentioned this pull request Aug 11, 2023
Merged
cloudwebrtc added a commit that referenced this pull request Aug 11, 2023
@cloudwebrtc
Revert "fix: partially rebuild RTCVideoView when renderVideo value ch…
59caea8 
…anges (#1406)" (#1418)

This reverts commit 99f8182.
@ycherniavskyi
Copy link
Member Author

I understand. Unfortunately, I don't have access to a Windows system at the moment. As soon as I obtain access, I will investigate the issue and work on implementing the necessary modification.

ycherniavskyi added a commit to WebTrit/flutter-webrtc that referenced this pull request Sep 4, 2023
@ycherniavskyi
fix: partially rebuild RTCVideoView when renderVideo value changes (f…
621bb43 
…lutter-webrtc#1406)
ycherniavskyi added a commit to WebTrit/flutter-webrtc that referenced this pull request Dec 5, 2023
@ycherniavskyi
fix: partially rebuild RTCVideoView when renderVideo value changes (f…
1b10e09 
…lutter-webrtc#1406)
ycherniavskyi added a commit to WebTrit/flutter-webrtc that referenced this pull request Feb 19, 2024
@ycherniavskyi
fix: partially rebuild RTCVideoView when renderVideo value changes (f…
c3fa176 
…lutter-webrtc#1406)
ycherniavskyi added a commit to WebTrit/flutter-webrtc that referenced this pull request Apr 15, 2024
@ycherniavskyi
fix: partially rebuild RTCVideoView when renderVideo value changes (f…
228751d 
…lutter-webrtc#1406)
digiboridev pushed a commit to WebTrit/flutter-webrtc that referenced this pull request Oct 14, 2024
@ycherniavskyi @digiboridev
fix: partially rebuild RTCVideoView when renderVideo value changes (f…
be8c87f 
…lutter-webrtc#1406)
digiboridev pushed a commit to WebTrit/flutter-webrtc that referenced this pull request Feb 4, 2025
@ycherniavskyi @digiboridev
fix: partially rebuild RTCVideoView when renderVideo value changes (f…
c788761 
…lutter-webrtc#1406)
SERDUN pushed a commit to WebTrit/flutter-webrtc that referenced this pull request Feb 27, 2025
@ycherniavskyi @SERDUN
fix: partially rebuild RTCVideoView when renderVideo value changes (f…
affb5f7 
…lutter-webrtc#1406)
daniel-g-favoreto-opl pushed a commit to daniel-g-favoreto-opl/flutter-webrtc that referenced this pull request Mar 24, 2025
@ycherniavskyi @daniel-g-favoreto-opl
fix: partially rebuild RTCVideoView when renderVideo value changes (f…
7f894d3 
…lutter-webrtc#1406)
daniel-g-favoreto-opl pushed a commit to daniel-g-favoreto-opl/flutter-webrtc that referenced this pull request Mar 24, 2025
@cloudwebrtc @daniel-g-favoreto-opl
Revert "fix: partially rebuild RTCVideoView when renderVideo value ch…
a100095 
…anges (flutter-webrtc#1406)" (flutter-webrtc#1418)

This reverts commit 99f8182.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudwebrtc cloudwebrtc cloudwebrtc approved these changes

@wer-mathurin wer-mathurin wer-mathurin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ycherniavskyi @cloudwebrtc @wer-mathurin
0