Enhance RTC video view with placeholder builder property #1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wer-mathurin
approved these changes
Dec 20, 2022
|
@cloudwebrtc and @ycherniavskyi: LGTM |
daniel-g-favoreto-opl
pushed a commit
to daniel-g-favoreto-opl/flutter-webrtc
that referenced
this pull request
Mar 24, 2025
…rtc#1206) * Enhance RTC video view with placeholder builder property * Assemble render video flag conditions of video renderer in one method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny enhancement of
RTCVideoViewallows simplifying add meaningful placeholder widget whileRTCVideoRendereris preparing/initialing.Also, I am going to use it within integration tests that automate app screenshots creation.