8000 Avoid renderer initialization multiple times by cloudwebrtc · Pull Request #1067 · flutter-webrtc/flutter-webrtc · GitHub
[go: up one dir, main page]
Skip to content

Avoid renderer initialization multiple times #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2022
Merged

Avoid renderer initialization multiple times #1067

merged 1 commit into from
Sep 14, 2022

Conversation

cloudwebrtc
Copy link
Member

No description provided.

wer-mathurin
wer-mathurin reviewed Aug 31, 2022
View reviewed changes
Copy link
Contributor
@wer-mathurin wer-mathurin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a general comment, there is multiple place that we are calling await without a try catch. So there is are potential bugs, but this is not the intent of this fix.

Other than that, LGTM

If you want to resolve the await in another PR. Just add a comment

@cloudwebrtc cloudwebrtc merged commit 939367f into main Sep 14, 2022
@cloudwebrtc cloudwebrtc deleted the avoid-renderer-init-multiple-times branch September 14, 2022 15:48
@duyjack duyjack mentioned this pull request Sep 20, 2022
Closed
duyjack pushed a commit to duyjack/flutter-webrtc that referenced this pull request Sep 20, 2022
@cloudwebrtc
Avoid renderer initialization multiple times (flutter-webrtc#1067)
fd1b7d5 
(cherry picked from commit 939367f)
@araguaci araguaci mentioned this pull request Oct 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wer-mathurin wer-mathurin wer-mathurin left review comments

@ycherniavskyi ycherniavskyi Awaiting requested review from ycherniavskyi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cloudwebrtc @wer-mathurin
0