Speakerphone #102
Merged
Speakerphone #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cloudwebrtc rebased to fix conflict |
cloudwebrtc
requested changes
Jun 4, 2019
| @@ -894,11 +900,21 @@ public void mediaStreamTrackSetVolume(final String id, final double volume) { | |||
| } | |||
| } | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Here is a conflicting diff tag, which causes compilation errors.
| public void mediaStreamTrackSetMicrophoneMute(final String id, boolean mute) { | ||
| try { | ||
| audioDeviceModule.setMicrophoneMute(mute); | ||
| } catch (Exception e) { | ||
| Log.e(TAG, "setMicrophoneMute(): error", e); | ||
| ======= |
There was a problem hiding this comment.
The same issue as above. And it looks like need to add
}
}to complete the body of the method.
| audioManager.setSpeakerphoneOn(enabled); | ||
| } catch (Exception e) { | ||
| Log.e(TAG, "setSpeakerphoneOn(): error", e); | ||
| >>>>>>> Add speakerphone support for Android |
There was a problem hiding this comment.
This is a conflict marker and should be removed.
|
@cloudwebrtc rebased again to fix conflict |
evdokimovs
added a commit
to evdokimovs/flutter-webrtc
that referenced
this pull request
Jun 6, 2024
Co-authored-by: alexlapa <lapa.alex@ex.ua>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for speakerphone feature in Android/iOS.