Remove unnecessary nullable types in examples. #176713
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request correctly removes unnecessary nullable types from onChanged callbacks in several examples, which improves code clarity and aligns with best practices. I've found
8000
one area where the implementation can be further improved for better readability and adherence to idiomatic Dart/Flutter code.
|
test-exempt: code refactor with no semantic change |
@dkwingsmt, me either. Thanks a lot for the review! According to the Gemini:
|
Description
bool?usage in examplesPre-laun 8000 ch Checklist
///).