Remove references to dart:_js_annotations #176698
Open
+0
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request removes references to the dart:_js_annotations library, which is no longer used in Flutter. The changes are consistent across the BUILD.gn and _embedder.yaml files, correctly removing the library import, copy tasks, dependencies, and embedder configurations. The modifications align with the stated goal of cleaning up an obsolete library reference. The changes are correct and I have no suggestions for improvement.
This library is now unused in Flutter and will shortly no longer build with dart2wasm anyway.
9525493 to
b527499
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library is now unused in Flutter and will shortly no longer build with dart2wasm anyway.
cc @srujzs