8000 Make sure that a MenuAcceleratorLabel doesn't crash in 0x0 environment by ahmedsameha1 · Pull Request #176646 · flutter/flutter · GitHub
[go: up one dir, main page]
Skip to content

Make sure that a MenuAcceleratorLabel doesn't crash in 0x0 environment #176646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make sure that a MenuAcceleratorLabel doesn't crash in 0x0 environment #176646

wants to merge 1 commit into from
+9 −0

Conversation

ahmedsameha1
Copy link
Contributor

This is my attempt to handle #6537 for the MenuAcceleratorLabel widget.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Oct 7, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 7, 2025
View reviewed changes
Copy link
Contributor
@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a regression test to ensure that MenuAcceleratorLabel does not crash when rendered in a zero-sized area. The new test case is well-written, clear, and accurately simulates the conditions described in the related issue by placing the widget within a SizedBox.shrink. This is a valuable addition to prevent future regressions of this specific crash.

@dkwingsmt dkwingsmt self-requested a review October 8, 2025 18:28
dkwingsmt
dkwingsmt approved these changes Oct 8, 2025
View reviewed changes
Copy link
Contributor
@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist:

  • The test is in the correct file
  • The test name goes “does not crash at zero area”
  • The target widget is wrapped by Center (or is fullscreen)
  • The target widget does not have an overlay, or the overlay is tested
  • The target widget is expected to have a size of exactly Size.zero

@dkwingsmt dkwingsmt requested a review from victorsanni October 10, 2025 04:54
@victorsanni victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 10, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 10, 2025
@auto-submit Auto-submit
Copy link
Contributor
auto-submit bot commented Oct 10, 2025

autosubmit label was removed for flutter/flutter/176646, because Pull request flutter/flutter/176646 is not in a mergeable state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

@victorsanni victorsanni victorsanni approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedsameha1 @dkwingsmt @victorsanni
0