10000 `CircularProgressIndicator` throws null exception by dbspoudel · Pull Request #163356 · flutter/flutter · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CircularProgressIndicator throws null exception #163356

Merged
merged 13 commits into from
Feb 20, 2025
Merged

CircularProgressIndicator throws null exception #163356

merged 13 commits into from
Feb 20, 2025
+20 −1

Conversation

dbspoudel
Copy link
Contributor
@dbspoudel dbspoudel commented Feb 14, 2025 •
edited
Loading

This PR adds a null check before accessing value, preventing errors caused by the null check operator used on null value.

Fixes #163253

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Feb 14, 2025
@dbspoudel dbspoudel mentioned this pull request Feb 15, 2025
Closed
@TahaTesser TahaTesser self-requested a review February 17, 2025 09:00
TahaTesser
TahaTesser requested changes Feb 17, 2025
View reviewed changes
Copy link
Member
@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you please a test to verify this fix?

@dbspoudel
Copy link
Contributor Author

Thanks for your contribution! Could you please a test to verify this fix?

I've already added and pushed the test. Let me know if any further changes are needed. Thanks

@dbspoudel
Copy link
Contributor Author

@TahaTesser could you please help me understand the failed check error and how to fix it?

@TahaTesser TahaTesser changed the title Fix Null check operator used on a null value CircularProgressIndicator throws null exception Feb 18, 2025
@TahaTesser
Copy link
Member

@TahaTesser could you please help me understand the failed check error and how to fix it?

The error messages reported above are repeated here:
  -- This line intentionally left blank --

The error seems to be related to blank line. Please format the code before pushing the changes. you can execute dart format .

@dbspoudel dbspoudel requested a review from TahaTesser February 18, 2025 11:41
@dbspoudel
Copy link
Contributor Author

@TahaTesser all requested changes have been made and pushed. Re-requesting your review. Thank you for your detailed guidance and continued support.

TahaTesser
TahaTesser requested changes Feb 18, 2025
View reviewed changes
Copy link
Member
@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do without these semantics lines.

@dbspoudel dbspoudel requested a review from TahaTesser February 18, 2025 18:51
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #163356 at sha 0fe753b

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Feb 19, 2025
TahaTesser
TahaTesser approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member
@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TahaTesser TahaTesser requested a review from bleroux February 19, 2025 15:58
< 10000 /div>
bleroux
bleroux approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor
@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution 🙏

@TahaTesser
Copy link
Member

@dbspoudel
could you please push an empty commit to re-trigger tests? git commit --allow-empty -m "Kick tests"

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 20, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Feb 20, 2025
Merged via the queue into flutter:master with commit fca021d Feb 20, 2025
75 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 20, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 20, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
fca021dee CircularProgressIndicator throws null exception (flutter/…
a67b1a7 
…flutter#163356)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 20, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
fca021dee CircularProgressIndicator throws null exception (flutter/…
cd09348 
…flutter#163356)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 20, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request 6D47 Feb 20, 2025
@engine-flutter-autoroll
fca021dee CircularProgressIndicator throws null exception (flutter/…
50857bc 
…flutter#163356)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 20, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
fca021dee CircularProgressIndicator throws null exception (flutter/…
2be3da5 
…flutter#163356)
@dbspoudel dbspoudel deleted the fix163253 branch February 21, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bleroux bleroux bleroux approved these changes

@TahaTesser TahaTesser TahaTesser approved these changes

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files
Projects
None yet
Milestone
No milestone
3 participants
@dbspoudel @TahaTesser @bleroux
0