10000 Allow flutter tools to detach a running Chrome session by biggs0125 · Pull Request #163349 · flutter/flutter · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow flutter tools to detach a running Chrome session #163349

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Allow flutter tools to detach a running Chrome session #163349

merged 4 commits into from
Feb 20, 2025
+97 −8

Conversation

biggs0125
Copy link
Contributor
@biggs0125 biggs0125 commented Feb 14, 2025 •
edited
Loading

#163329

Tested locally to ensure pressing 'd' in a running flutter run session detaches and leaves Chrome open. Hitting 'q' or stopping with a signal both terminate Chrome as expected.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@biggs0125 biggs0125 requested review from srujzs and bkonyi February 14, 2025 22:44
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 14, 2025
srujzs
srujzs approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor
@srujzs srujzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Nate!

@biggs0125 biggs0125 added this pull request to the merge queue Feb 19, 2025
Merged via the queue into flutter:master with commit 4b2a52f Feb 20, 2025
137 of 138 checks passed
@biggs0125 biggs0125 deleted the allow-web-detach branch February 20, 2025 00:28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 20, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
4b2a52fdf Allow flutter tools to detach a running Chrome session (flu…
b907141 
…tter/flutter#163349)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 20, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
4b2a52fdf Allow flutter tools to detach a running Chrome session (flu…
90f4156 
…tter/flutter#163349)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 20, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
4b2a52fdf Allow flutter tools to detach a running Chrome session (flu…
09fd01a 
…tter/flutter#163349)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 20, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2025
@engine-flutter-autoroll
4b2a52fdf Allow flutter tools to detach a running Chrome session (flu…
df12d88 
…tter/flutter#163349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkonyi bkonyi bkonyi approved these changes

@srujzs srujzs srujzs approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@biggs0125 @bkonyi @srujzs @natebiggs
0