Qodana fixes by jnyrup · Pull Request #2229 · fluentassertions/fluentassertions

jnyrup · 2023-07-02T12:53:47Z

Went through the Qodana report and here are fixes to some that should be non-controversial.
This is in addition to be fixed in #2221.

There are a lot of warnings about unused methods/return values of public methods.
To silence them, it seems the idiomatic way is to annotate them with [PublicAPI]

IMPORTANT

If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
The code complies with the Coding Guidelines for C#.
The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
- Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

This should silence warnings about possible multiple enumerations

coveralls · 2023-07-02T13:03:47Z

Pull Request Test Coverage Report for Build 5436628597

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

56 of 59 (94.92%) changed or added relevant lines in 11 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.008%) to 97.222%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
Src/FluentAssertions/Equivalency/MemberFactory.cs	4	5	80.0%
Src/FluentAssertions/Equivalency/Steps/DataRowCollectionEquivalencyStep.cs	7	8	87.5%
Src/FluentAssertions/Numeric/NumericAssertions.cs	9	10	90.0%

Files with Coverage Reduction	New Missed Lines	%
Src/FluentAssertions/Types/TypeSelector.cs	2	97.81%

Totals
Change from base Build 5356506609:	0.008%
Covered Lines:	12859
Relevant Lines:	13101

💛 - Coveralls

lg2de · 2023-07-03T07:09:53Z

There are a lot of warnings about unused methods/return values of public methods.
To silence them, it seems the idiomatic way is to annotate them with [PublicAPI]

Public API shall be used by the unit tests.
So, it should be used, incl. return values, isn't it?

jnyrup · 2023-07-03T09:14:30Z

There are a lot of warnings about unused methods/return values of public methods.
To silence them, it seems the idiomatic way is to annotate them with [PublicAPI]

Public API shall be used by the unit tests. So, it should be used, incl. return values, isn't it?

Examples:
DateTimeAssertions.BeOneOf(IEnumerable<DateTime?> validValues, string because = "", params object[] becauseArgs) is marked with Member can be made private (non-private accessibility).
It is never called directly by unit tests, only from other overloads of DateTimeAssertions.BeOneOf.

The same method is also marked Method return value is never used because we exercise the chainability in the unit tests.

Unless we explicitly exercise all overloads including their chainability, I assume adding [PublicAPI] is the way to silence these warnings.
Note: I'm completely new to Qodana, so I'm open to suggestions.

lg2de · 2023-07-03T10:10:36Z

It is never called directly by unit tests, only from other overloads of DateTimeAssertions.BeOneOf.

Is there a reason to not test it directly?

If we would follow the rule and making the method private, only the API verification would fail because a method is missing.
But, there is not test validating the behavior of this method. It may get broken with internal refactoring.
I would argue for direct testing every public method directly.

I could help to provide such tests, but so far I did not find access to the Qodana report.

qodana.yaml

Src/FluentAssertions/Common/Guard.cs

Src/FluentAssertions/Types/TypeSelector.cs

Src/FluentAssertions/CallerIdentification/AddNonEmptySymbolParsingStrategy.cs

…null value

jnyrup added 4 commits July 2, 2023 14:09

Tell Qodana that object is not enumerated

3a6db0b

This should silence warnings about possible multiple enumerations

Add Qodana exclusions

bf51391

Use preferred style of 'new' expression when created type is evident

e382c7f

'if' statement can be rewritten as '??=' assignment

bb4228e

jnyrup requested a review from dennisdoomen July 2, 2023 12:54

dennisdoomen reviewed Jul 3, 2023

View reviewed changes

qodana.yaml Show resolved Hide resolved

Src/FluentAssertions/Common/Guard.cs Show resolved Hide resolved

Src/FluentAssertions/Types/TypeSelector.cs Outdated Show resolved Hide resolved

Src/FluentAssertions/CallerIdentification/AddNonEmptySymbolParsingStrategy.cs Show resolved Hide resolved

dennisdoomen approved these changes Jul 4, 2023

View reviewed changes

jnyrup added 9 commits July 4, 2023 13:05

Combine ifs

451f3bf

Convert 'if' statement into 'switch'

f0afff8

Loop can be converted into LINQ-expression

9d7d3e5

Use null check pattern instead of a type check succeeding on any not-…

7c0b41a

…null value

Redundant using directive

94f09bc

Member initialized value ignored

f08a20b

Possible unintended reference comparison

517ea42

Destination has the same value before assignment

92d5304

Conditional access qualifier expression is known to be null or not null

d695ddf

jnyrup force-pushed the jn/quodana branch from aad3a74 to d695ddf Compare July 4, 2023 11:06

jnyrup merged commit 92fe883 into fluentassertions:develop Jul 4, 2023

jnyrup deleted the jn/quodana branch July 4, 2023 11:24

jnyrup added the building Building and Infrastructure of Fluent Assertions label Aug 19, 2023

This was referenced Oct 13, 2025

Bump FluentAssertions from 6.11.0 to 8.7.1 fgrzl/gravel#9

Closed

Bump FluentAssertions from 5.10.3 to 8.7.1 openwallet-foundation-labs/wallet-framework-dotnet#421

Closed

This was referenced Oct 27, 2025

Bump FluentAssertions from 5.10.3 to 8.8.0 openwallet-foundation-labs/wallet-framework-dotnet#441

Closed

Bump FluentAssertions from 5.10.3 to 8.8.0 openwallet-foundation-labs/wallet-framework-dotnet#445

Closed

This was referenced Nov 10, 2025

Bump FluentAssertions from 5.10.3 to 8.8.0 openwallet-foundation-labs/wallet-framework-dotnet#452

Closed

Bump FluentAssertions from 5.10.3 to 8.8.0 openwallet-foundation-labs/wallet-framework-dotnet#469

Closed

This was referenced Nov 24, 2025

Bump FluentAssertions from 5.10.3 to 8.8.0 openwallet-foundation-labs/wallet-framework-dotnet#476

Closed

Bump FluentAssertions from 5.10.3 to 8.8.0 jleachenski/AspNetCore-DDD#12

Open

This was referenced Dec 22, 2025

Bump FluentAssertions from 5.10.3 to 8.8.0 petrikero/akka.net#34

Open

Bump FluentAssertions from 5.10.3 to 8.8.0 ChrisKXu/todl#122

Closed

dependabot bot mentioned this pull request Jan 1, 2026

Bump FluentAssertions from 6.10.0 to 8.8.0 JensKrumsieck/PorphyStruct#126

Open

This was referenced Jan 11, 2026

Bump FluentAssertions from 5.10.3 to 8.8.0 thashiznit2003/Bookdarr#9

Merged

Bump FluentAssertions from 6.4.0 to 8.8.0 angeldev99/dotnet-reactive#2

Open

dependabot bot mentioned this pull request Feb 8, 2026

Bump FluentAssertions from 6.6.0 to 8.8.0 WaterLemons2k/BililiveRecorder#19

Merged

This was referenced Mar 2, 2026

Bump FluentAssertions from 6.8.0 to 8.8.0 devpro/withywoods#374

Closed

Bump FluentAssertions from 5.10.3 to 8.8.0 RocketSurgeonsGuild/ReactiveUI.Interop#335

Open

dependabot bot mentioned this pull request Mar 10, 2026

Bump FluentAssertions from 6.11.0 to 8.8.0 rmdias/S13G#3

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Qodana fixes#2229

Qodana fixes#2229
jnyrup merged 13 commits intofluentassertions:developfrom
jnyrup:jn/quodana

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

IMPORTANT

Uh oh!

Uh oh!

Pull Request Test Coverage Report for Build 5436628597

Warning: This coverage report may be inaccurate.

💛 - Coveralls

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants